convert calls to retry to retry_until#777
Conversation
|
@categulario It has some |
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 75.59% 75.59%
=======================================
Files 16 16
Lines 1254 1254
Branches 322 322
=======================================
Hits 948 948
Misses 220 220
Partials 86 86 Continue to review full report at Codecov.
|
tony
left a comment
There was a problem hiding this comment.
LGTM
P.S. I created an issue to improve assertion rewriting with retry_until: tmux-python/libtmux#376
|
@categulario P.S. Is this still a WIP? Think its good to go in? |
not anymore! (: |
|
@categulario Live in v1.12.0a4 pypi, branch, tag |
|
@categulario Woops, forgot to credit you in the |
|
@categulario Added mention of you in changelog. That okay, or do you want it changed to be your name? v1.12.0a5 released |
|
Yaay, thank you. categulario is my name for the internet so that's ok (: |
|
Sounds good! |
One test still resists to pass, I think it is the one that didn't pass before retry_until