Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 1, 2021

inspect.getargspec has been deprecated since Python 3.0. Use inspect.getfullargspec instead (python/cpython#28618).

https://docs.python.org/3.9/library/inspect.html?highlight=getargspec#inspect.getargspec

This is only used in tests/memory_profiling.py.

There's also a use in pyrsistent/_field_common.py, but only for Python 2. Python 2 isn't supported any more, so let's remove some redundant Python 2 code whilst we're at it.

@tobgu
Copy link
Owner

tobgu commented Oct 3, 2021

Great, many thanks!

@tobgu tobgu merged commit d859d62 into tobgu:master Oct 3, 2021
@hugovk hugovk deleted the replace-deprecated branch October 3, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants