Replace _PyList_Extend with PyList_SetSlice #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This private function is no longer exported in Python 3.13. It is possible that a PyList_Extend() function-like macro may be added before Python 3.13 final, but using PyList_SetSlice() directly will still work. python/cpython#108451 python/cpython#111138
Owner
|
Thanks! Sorry for taking so long to review it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This private function is no longer exported in Python 3.13.
It is possible that a
PyList_Extend()function-like macro may be added before Python 3.13 final, but usingPyList_SetSlice()directly will still work.See also:
python/cpython#108451
python/cpython#111138
After this PR,
pyrsistentbuilds and the tests pass on Python 3.13.0a1.