Fix release asset naming to match README documentation#16
Open
rgarcia wants to merge 1 commit intotobi:masterfrom
Open
Fix release asset naming to match README documentation#16rgarcia wants to merge 1 commit intotobi:masterfrom
rgarcia wants to merge 1 commit intotobi:masterfrom
Conversation
The CI workflow was producing assets named `try-x86_64-linux.tar.gz` (arch-os format) but the README documents `try-linux-x86_64.tar.gz` (os-arch format), causing the install commands to fail. This fixes the "Prepare release assets" step to rename artifacts from arch-os to os-arch format during packaging. Also updates README to: - Add Linux aarch64 install instructions - Note that macOS pre-built binaries are not currently available (darwin cross-compile was removed in v1.5.2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try-linux-x86_64.tar.gzinstead oftry-x86_64-linux.tar.gz)Problem
The install command documented in the README fails with
gzip: stdin: not in gzip format:curl -sL https://github.com/tobi/try-cli/releases/latest/download/try-linux-x86_64.tar.gz | tar xzThis happens because the README documents assets named
try-linux-x86_64.tar.gz(os-arch format), but the CI workflow produces assets namedtry-x86_64-linux.tar.gz(arch-os format).Solution
Update the "Prepare release assets" step in the CI workflow to rename artifacts from
try-{arch}-{os}totry-{os}-{arch}format during packaging, matching the documented URLs.Test plan
curl -sL https://github.com/tobi/try-cli/releases/latest/download/try-linux-x86_64.tar.gz | tar xz