Open
Conversation
Use `string collect` in the fish wrapper generated by `try init` so multi-line output from `try exec` is evaluated as one script. Also capture `pipestatus[1]` and return it on failure instead of relying on `$status` from the pipeline tail.
Use `command try` in Fish init snippets so re-sourcing shell config always calls the binary, not an already-defined `try` function. This keeps setup idempotent and avoids recursion/weird behavior when config.fish is sourced multiple times.
|
Had same issue when switching from ruby to c version. Built from mineiro:fix/fish-init-wrapper and used the corrected init code and it worked as expected. fish version 4.4.0 The broken behaviour led to a lot of needless troubleshooting until I found this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Fish try behavior (create/clone + status) and updates README to the safer command try init ... setup.