fix!: Add support for Athena's Iceberg partitioning transforms#4976
Merged
fix!: Add support for Athena's Iceberg partitioning transforms#4976
Conversation
b603827 to
6789fd3
Compare
6789fd3 to
9dcd887
Compare
georgesittas
approved these changes
Apr 15, 2025
tobymao
approved these changes
Apr 15, 2025
Collaborator
|
Let's verify that this fixes the linked SQLMesh issue. |
Collaborator
Author
If I'm not mistaken this is one part of the fix; The other part would be parsing the |
Collaborator
|
I see, makes sense, thanks for clarifying. |
erindru
approved these changes
Apr 15, 2025
Collaborator
erindru
left a comment
There was a problem hiding this comment.
This looks correct, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #4962
This PR introduces the expressions
exp.PartitionedByBucketandexp.PartitionedByTruncatewhich control the generation of Iceberg transforms:CREATE TABLE) demandsBUCKET(n, col)/TRUNCATE(n, col)BUCKET(col, n)/TRUNCATE(col, n)Note: The
PARTITIONED BYproperty attempts to parse a schema, so the new expressions are parsed as "constraints" since_parse_schema()ends up parsing_parse_constraint() or _parse_column_def().