feat(snowflake): add support for GET statements#5019
Merged
VaggelisD merged 4 commits intotobymao:mainfrom Apr 29, 2025
Merged
Conversation
VaggelisD
reviewed
Apr 29, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Hey @eruditmorina, thank you for the contribution!
Left a few comments from my first pass:
VaggelisD
reviewed
Apr 29, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Just a couple more comments to consider from me and I think this is g2g
georgesittas
approved these changes
Apr 29, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Thanks for your contribution @eruditmorina!
VaggelisD
approved these changes
Apr 29, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Awesome work, thank you for the contribution & quick iterations!
|
I started getting errors from sqlglot improperly parsing 'get' used in this context: https://docs.snowflake.com/en/sql-reference/functions/get |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hi folks, following up on #4813 in order to add support for
GETstatements in snowflake dialect similarly to the wayPUTstatements are being handled.Changes
GETexpression and TokenType_parse_getwhich parsesGETstatements toexp.Get, except for the case of unquoted file path (treated asexp.Command)Thank you for the support 🙌