fix(postgres)!: Preserve quoting for user defined types#5216
Merged
Conversation
Collaborator
What if you include unsafe characters though that need to be delimited? E.g. |
Collaborator
georgesittas
left a comment
There was a problem hiding this comment.
@VaggelisD this fails in duckdb now:
>>> import sqlglot
>>> sqlglot.parse_one('cast(x as "foo bar")', 'duckdb')
Cast(
this=Column(
this=Identifier(this=x, quoted=False)),
to=DataType(this=Type.USERDEFINED, kind=foo bar))
>>> sqlglot.parse_one('cast(x as "foo bar")', 'duckdb').sql('duckdb')
'CAST(x AS foo bar)'
georgesittas
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5212
I went ahead and fixed this for Postgres only; It seems to be one of the few dialects that supports user defined types and the identifier resolution is respected:
DuckDB also supports UDTs but quoting doesn't seem to make a difference:
Lastly, T-SQL also allows UDTs, but the approach of this PR wouldn't work because T-SQL also supports such statements (notice the builtin quoted type)
Which would be transpiled as the identifier
"VARCHAR"to other dialects.