Feat(snowflake): add autoincrement order clause support#5223
Merged
georgesittas merged 7 commits intotobymao:mainfrom Jun 16, 2025
Merged
Feat(snowflake): add autoincrement order clause support#5223georgesittas merged 7 commits intotobymao:mainfrom
georgesittas merged 7 commits intotobymao:mainfrom
Conversation
Collaborator
|
Hey, thanks for the PR, we'll take a look soon. You can run |
Comment on lines
+5915
to
+5916
| show_order = None | ||
| order = None |
Collaborator
There was a problem hiding this comment.
This doesn't look right, we should only introduce order and then treat None as "does not exist" / "don't show".
Collaborator
|
I'll get this in and take it to the finish line. Thanks! |
Collaborator
|
See here: 7d966e6 |
Contributor
Author
|
Thank you very much, really appreciate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR solve the
return :