Feat(snowflake): improve transpilation of unnested object lookup#5234
Merged
georgesittas merged 2 commits intomainfrom Jun 17, 2025
Merged
Feat(snowflake): improve transpilation of unnested object lookup#5234georgesittas merged 2 commits intomainfrom
georgesittas merged 2 commits intomainfrom
Conversation
VaggelisD
reviewed
Jun 17, 2025
660ac91 to
e78f8c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
walk_in_scopelogic to stop considering plainUDTFs withoutQuerychildren as scope boundariesWe incorrectly transpile BigQuery queries like the following to Snowflake today:
The resulting query fails with
Error: invalid identifier '_U.FOO' (line 1), because the value_uis aVARIANT, and so accessing its contents using the dot notation is not allowed. Instead, Snowflake requires that we use either the colon (x:y) or the bracket syntaxx['y']for this reason.To address this, the new transformation looks for unnests that have a single column alias, and then replaces any columns in scope that are qualified with said alias.
I looked into Snowflake's docs for
TABLE(FLATTEN(...)), and I believe the expected receivers of the lookup operation should beOBJECTorVARIANTvalues, for which it is safe to replace the dot syntax with the bracket notation.