feat(fabric): Ensure TIMESTAMPTZ is used with AT TIME ZONE#5362
feat(fabric): Ensure TIMESTAMPTZ is used with AT TIME ZONE#5362georgesittas merged 3 commits intotobymao:mainfrom
Conversation
georgesittas
left a comment
There was a problem hiding this comment.
Thanks for the PR @mattiasthalen!
|
Is there something else pending for this PR on your end? Looks good to go. |
Yeah, but I'm not sure if the error is here or in SQLMesh 😄 But now it's back to: But I'm struggling in general to see the query actually executed. |
|
Can you see the queries executed under |
I think I've narrowed the issue down. |
|
@mattiasthalen let me know when this is ready to be merged. |
|
Will mark ready ASAP, just want to check a couple of things |
5dffef6 to
07e75f7
Compare
This pull request updates the handling of
TIMESTAMPTZandDATETIMEOFFSETtypes in the Fabric SQL dialect to ensure compliance with Microsoft Fabric's requirements. It introduces logic to differentiate howTIMESTAMPTZis treated based on whether it is used in anAT TIME ZONEexpression and adjusts test cases accordingly.Changes to
TIMESTAMPTZandDATETIMEOFFSEThandling:TIMESTAMPTZindatatype_sql:TIMESTAMPTZinAT TIME ZONE 'UTC'whenAT TIME ZONEis missing.Updates to test cases:
Modified precision handling for
DATETIMEOFFSET:DATETIMEOFFSETis only valid when paired withAT TIME ZONE, preserving precision limits.Added new test for
TIMESTAMPTZbehavior:TIMESTAMPTZis used withAT TIME ZONE.