Conversation
Collaborator
|
Was this benchmarked? I've two branches where I refactored the implementations as well (2 different ways), but they were slower compared to our current implementation and we decided to not use them. Will review tomorrow, haven't checked whether/how they're different from the approach here. |
Owner
Author
|
Yea, it could be faster. It also leverages caching in better ways. So it should make the optimizer way faster too. |
VaggelisD
reviewed
Sep 26, 2025
georgesittas
approved these changes
Sep 26, 2025
Collaborator
georgesittas
left a comment
There was a problem hiding this comment.
Nice work. I'd add this test as well to demonstrate that the PR solves the issue:
def test_hash_large_asts(self):
# Ensures we can actually compare large ASTs and not fail due to exceeding recursion limit
ast = parse_one("SELECT 1 UNION ALL " * 500 + "SELECT 1")
assert isinstance(hash(ast), int)
georgesittas
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.