feat(optimizer): Annotate type for snowflake MOD function#6031
Merged
georgesittas merged 3 commits intomainfrom Oct 8, 2025
Merged
feat(optimizer): Annotate type for snowflake MOD function#6031georgesittas merged 3 commits intomainfrom
georgesittas merged 3 commits intomainfrom
Conversation
fivetran-amrutabhimsenayachit
requested review from
Copilot,
fivetran-BradfordPaskewitz,
geooo109 and
georgesittas
and removed request for
Copilot
georgesittas
reviewed
Oct 8, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
I'll get this in and add the tests back.
Comment on lines
-326
to
-336
| # dialect: bigquery | ||
| FLOOR(1); | ||
| DOUBLE; | ||
|
|
||
| # dialect: bigquery | ||
| FLOOR(5.5); | ||
| DOUBLE; | ||
|
|
||
| # dialect: bigquery | ||
| FLOOR(tbl.bignum_col); | ||
| BIGDECIMAL; |
Collaborator
There was a problem hiding this comment.
Was this an oversight? Removing them doesn't look right.
Collaborator
Author
There was a problem hiding this comment.
It got added from the PR - #6030, removed this code since it is not related to MOD.
Collaborator
There was a problem hiding this comment.
These tests are not the same as those added in #6030 though, they're targeting BigQuery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate type for snowflake MOD function.
Documentation:
https://docs.snowflake.com/en/sql-reference/functions/mod