Skip to content

feat(optimizer)!: annotate type for Snowflake SINH function #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geooo109 merged 1 commit into from
Oct 9, 2025
Merged

feat(optimizer)!: annotate type for Snowflake SINH function #6052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/dialects/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ class Snowflake(Dialect):
exp.Degrees,
exp.Exp,
exp.Sin,
exp.Sinh,
exp.Tan,
exp.Asin,
exp.Cbrt,
Expand Down
1 change: 1 addition & 0 deletions tests/dialects/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def test_snowflake(self):
self.validate_identity("SELECT GET(a, b)")
self.validate_identity("SELECT TAN(x)")
self.validate_identity("SELECT COS(x)")
self.validate_identity("SELECT SINH(1.5)")
self.validate_identity("SELECT MOD(x, y)", "SELECT x % y")
self.validate_identity("SELECT ROUND(x)")
self.validate_identity("SELECT ROUND(123.456, -1)")
Expand Down
8 changes: 8 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2243,6 +2243,14 @@ VARCHAR;
SIN(tbl.double_col);
DOUBLE;

# dialect: snowflake
SINH(1);
DOUBLE;

# dialect: snowflake
SINH(1.5);
DOUBLE;

# dialect: snowflake
SIGN(tbl.double_col);
INT;
Expand Down