Skip to content

feat(optimizer)!: Annotate type for snowflake ATAN2 function. #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 2 commits into from
Oct 9, 2025
Merged

feat(optimizer)!: Annotate type for snowflake ATAN2 function. #6060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2a2d7
feat(optimizer): Annotate type for snowflake ATAN2 function
fivetran-amrutabhimsenayachit Oct 9, 2025
48277a5
fix: Removed extra test
fivetran-amrutabhimsenayachit Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/dialects/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@ class Snowflake(Dialect):
exp.Sin,
exp.Tan,
exp.Asin,
exp.Atan2,
exp.Atanh,
exp.Cbrt,
},
Expand Down
1 change: 1 addition & 0 deletions tests/dialects/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def test_snowflake(self):
self.validate_identity("SELECT SOUNDEX_P123(column_name)")
self.validate_identity("SELECT ABS(x)")
self.validate_identity("SELECT ASIN(0.5)")
self.validate_identity("SELECT ATAN2(0.5, 0.3)")
self.validate_identity("SELECT ATANH(0.5)")
self.validate_identity("SELECT CBRT(27.0)")
self.validate_identity("SELECT SIGN(x)")
Expand Down
4 changes: 4 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,6 +1547,10 @@ DOUBLE;
ASIN(tbl.double_col);
DOUBLE;

# dialect: snowflake
ATAN2(tbl.double_col, tbl.double_col);
DOUBLE;

# dialect: snowflake
ATANH(tbl.double_col);
DOUBLE;
Expand Down