feat(duckdb): transpile bigquery's BYTES variant of REPLACE#6312
Merged
georgesittas merged 3 commits intomainfrom Nov 12, 2025
Merged
feat(duckdb): transpile bigquery's BYTES variant of REPLACE#6312georgesittas merged 3 commits intomainfrom
BYTES variant of REPLACE#6312georgesittas merged 3 commits intomainfrom
Conversation
VaggelisD
reviewed
Nov 12, 2025
Collaborator
|
Seems like a recurring pattern is emerging, see also: https://github.com/tobymao/sqlglot/pull/6240/files. |
f2086b3 to
98f8d2d
Compare
georgesittas
approved these changes
Nov 12, 2025
BYTES variant of REPLACE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery's REPLACE() can be used like
STRING --> STRINGandBYTES --> BYTES. DuckDB's REPLACE() only supportsSTRING --> STRING. This PR allows casts the byte arguments to strings (if the types are known/annotated).Current DuckDB behavior:
After casting implementation: