feat(duckdb): preserve time zone and timestamp in DATE_TRUNC()#6318
Merged
georgesittas merged 2 commits intomainfrom Nov 14, 2025
Merged
feat(duckdb): preserve time zone and timestamp in DATE_TRUNC()#6318georgesittas merged 2 commits intomainfrom
georgesittas merged 2 commits intomainfrom
Conversation
…ssion with date granularity in duckdb
Collaborator
|
@toriwei some of these tests seem to be failing because of a time zone discrepancy: BigQuery returns |
toriwei
commented
Nov 14, 2025
georgesittas
approved these changes
Nov 14, 2025
Collaborator
georgesittas
left a comment
There was a problem hiding this comment.
Great work @toriwei, thanks for improving the test coverage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery's TIMESTAMP_TRUNC() maps to DuckDB's DATE_TRUNC()
BigQuery's function can be used like
TIMESTAMP_TRUNC(timestamp, date_granularity, timezone), which transpiles incorrectly into DuckDB.BigQuery Behavior
DuckDB Changes
The inner
AT TIME ZONEensures datetime is in the specified timezone before truncating.We add the outer
AT TIME ZONEto preserve the timestamp component.