fix(tsql)!: handle all datepart alternatives#6324
Merged
georgesittas merged 10 commits intotobymao:mainfrom Nov 18, 2025
Merged
fix(tsql)!: handle all datepart alternatives#6324georgesittas merged 10 commits intotobymao:mainfrom
georgesittas merged 10 commits intotobymao:mainfrom
Conversation
Co-authored-by: Lulzim Bilali <lulzim.bilali@akersolutions.com>
DATEPART works for all of tsql datepart options and abbreviations
# Conflicts: # tests/dialects/test_tsql.py
Contributor
Author
|
did not add tests yet, |
lBilali
changed the title
georgesittas
changed the title
Collaborator
|
Thank you for the contribution, btw! Great catches. |
added 6 commits
November 17, 2025 12:18
This reverts commit 712f2a8.
georgesittas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR changes DATEPART such that all its part and abbreviations are supported
https://learn.microsoft.com/en-us/sql/t-sql/functions/datepart-transact-sql?view=sql-server-ver17