Conversation
| if k not in self.arg_types: | ||
| errors.append(f"Unexpected keyword: '{k}' for {self.__class__}") | ||
| for k, mandatory in self.arg_types.items(): | ||
| if UNITTEST: |
There was a problem hiding this comment.
the check for unknown args only runs at parse time. so for 3rd party
libraries or other code like the optimizer setting args or creating
expressions themselves, it's never checked it or worked. moving this to
unit testing only.
|
/benchmark |
the check for unexpected args only runs at parse time. so for 3rd party libraries or other code like the optimizer setting args or creating expressions themselves, it's never checked it or worked. moving this to unit testing only.
tobymao
force-pushed
the
toby/arg_cleanup
branch
from
5fd20d4 to
3954773
Compare
|
/benchmark |
Benchmark ResultsLegend:
Parsing Benchmark
Benchmark hidden because not significant (6): parse_sqlglot_tpch, parse_sqlglot_short, parse_sqlglot_long, parse_sqlglot_crazy, parse_sqlglotrs_tpch, parse_sqlglotrs_long Optimization Benchmark
Benchmark hidden because not significant (3): optimize_tpch, optimize_condition_10, optimize_condition_1000 |
Benchmark ResultsLegend:
Parsing Benchmark
Benchmark hidden because not significant (4): parse_sqlglot_tpch, parse_sqlglotrs_tpch, parse_sqlglotrs_short, parse_sqlglotrs_crazy Optimization Benchmark
Benchmark hidden because not significant (3): optimize_condition_10, optimize_condition_100, optimize_condition_1000 |
|
/benchmark |
Benchmark ResultsLegend:
Parsing BenchmarkBenchmark hidden because not significant (8): parse_sqlglot_tpch, parse_sqlglot_short, parse_sqlglot_long, parse_sqlglot_crazy, parse_sqlglotrs_tpch, parse_sqlglotrs_short, parse_sqlglotrs_long, parse_sqlglotrs_crazy Optimization BenchmarkBenchmark hidden because not significant (4): optimize_tpch, optimize_condition_10, optimize_condition_100, optimize_condition_1000 |
|
|
||
| key = "expression" | ||
| arg_types = {"this": True} | ||
| required_args = {"this"} |
2 participants
No description provided.