Change offset without changing time#1
Merged
barelyknown merged 2 commits intoOct 6, 2015
Conversation
Member
|
Oh, cool. Thanks. |
barelyknown
added a commit
that referenced
this pull request
Oct 6, 2015
Change offset without changing time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
Thanks for making this pull request - I was implementing it but I realised that it was breaking my tests - the reason was that it was changing the time along with the offset - what we want is for the offset only to be changed. I made a simple change which does this, which also doesn't break any of your specs - I've another spec which checks that the time doesn't change when the timezone is not UTC.
Thanks again 🚀