Fix lazy api loading #169
Open
Fix lazy api loading #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 27, 2026 13:34
lulco
reviewed
Jan 27, 2026
| 'authorization' => get_class($api->getAuthorization()), | ||
| 'url' => $this->apiLink->link($api->getEndpoint()), | ||
| 'params' => $this->createParamsList($api->getHandler()), | ||
| 'params' => $this->createParamsList($this->apiDecider->getHandler($api)), |
Collaborator
There was a problem hiding this comment.
takto som to mal predtym? ten kod tu https://github.com/tomaj/nette-api/pull/149/changes je iny. Mame podla mna tie lazy handlery na eboxe a toto som tam nerobil urcite 🤔
Contributor
Author
There was a problem hiding this comment.
No to mi vyhadzuje pstan ze nemoze byt string v tych funkciach cize potrebujeme tam iba ApiHandler. A v API moze byt aj string ulozeny.
Collaborator
There was a problem hiding this comment.
a nemoze? nejde to tak? nie je to len zly typehint a phpstan je zmateny?
Contributor
Author
There was a problem hiding this comment.
Nemyslim lebo napriklad tu je potrebne $handler->params() cize na stringu to muselo padnut.
Contributor
Author
There was a problem hiding this comment.
To iste aj na open api a ApiPresenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.