Issue #41 Fix value of 'algorithm' field when signing algorithm is set to 'hs2019'#36
Merged
jeanouii merged 2 commits intotomitribe:masterfrom Jun 17, 2020
Merged
Conversation
jeanouii
approved these changes
Jun 11, 2020
Member
jeanouii
left a comment
There was a problem hiding this comment.
This is a bug and needs to go in the release notes, so ticket is required here in my opinion. Can you do that?
Contributor
Author
I have created #41. |
Contributor
Author
@jeanouii , is there anything else you need before these three PRs can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #41.
When the signing algorithm is set to 'hs2019', the value of the 'algorithm' field in the Authorization header must be set to hs2019. Previously it was set to the actual cryptographic algorithm, such as rsa-sha256. When the signing algorithm is something other than 'hs2019', the value of the 'algorithm' field remains as it was before.
Example:
versus: