refactor(cscore): in-code-dokumentation und bridge-randfaelle stabilisieren#127
Merged
tomtastisch merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
bot
added
area:docs
area:versioning
area:tests
feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes Phase C of the 6.1.x production finalization by refactoring the CsCoreRuntimeBridge for better maintainability, harmonizing in-code XML documentation with consistent German umlaut spelling, adding edge-case tests for fail-closed delegation/fallback behavior, and converging all version references to 6.1.17.
Changes:
- Extracted duplicate tuple-parsing logic into dedicated helper methods (
TryReadHmacResolutionTuple,TryReadArchivePathTuple) - Consolidated assembly path resolution logic into a shared
TryResolveAssemblyFromDirectoryhelper - Harmonized XML documentation comments to use consistent German umlaut spelling (Brücke, Rückgabe, Prüfung, Länge)
- Added two new edge-case tests verifying fail-closed behavior for path traversal and invalid Base64 input
- Updated version to 6.1.17 across all project files and documentation
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FileTypeDetectionLib.Tests/Unit/CsCoreUtilityBridgeUnitTests.cs | Added two edge-case tests verifying fail-closed behavior for archive path normalization with traversal attempts and HMAC key resolution with invalid Base64 |
| src/FileTypeDetection/Infrastructure/Utils/CsCoreRuntimeBridge.vb | Refactored to extract duplicate tuple-parsing and assembly resolution logic into reusable helpers; harmonized XML documentation with consistent German umlaut spelling; added comprehensive documentation for new helper methods |
| src/FileTypeDetection/FileTypeDetectionLib.vbproj | Bumped Version and PackageVersion from 6.1.16 to 6.1.17 |
| docs/versioning/103_CHANGELOG_RELEASES.MD | Added 6.1.17 changelog entry documenting the bridge refactoring, documentation harmonization, and test additions |
| docs/versioning/102_HISTORY_VERSIONS.MD | Updated current working state to v6.1.17 and added version history entry |
| docs/versioning/003_CHANGELOG_RELEASES.MD | Added 6.1.17 changelog entry (German version) |
| docs/versioning/002_HISTORY_VERSIONS.MD | Updated current working state to v6.1.17 and added version history entry (German version) |
| docs/1_en/versioning/003_CHANGELOG_RELEASES.MD | Added 6.1.17 changelog entry (English mirror) |
| docs/1_en/versioning/002_HISTORY_VERSIONS.MD | Updated current working state to v6.1.17 and added version history entry (English mirror) |
| docs/0_de/versioning/003_CHANGELOG_RELEASES.MD | Added 6.1.17 changelog entry (German docs folder) |
| docs/0_de/versioning/002_HISTORY_VERSIONS.MD | Updated current working state to v6.1.17 and added version history entry (German docs folder) |
| Directory.Build.props | Bumped RepoVersion from 6.1.16 to 6.1.17 |
tomtastisch
deleted the
codex/refactor/6-1-17-incode-doc-and-bridge-hardening
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ziel & Scope
Phase C der 6.1.x-Produktionsfinalisierung: Bridge-Randfälle und In-Code-Dokumentation ohne Public-API-Änderung stabilisieren, inklusive Versionskonvergenz auf
6.1.17.Umgesetzte Aufgaben (abhaken)
CsCoreRuntimeBridgestrukturell entdoppelt (Tuple-Reader-Helper + gemeinsame Assembly-Directory-Probe).<b>/<br/>-Blöcke an Hover-relevanten Stellen ergänzt.NormalizeArchiveRelativePath,ResolveHmacKeyFromEnvironment).6.1.17inRepoVersion,Version,PackageVersiongesetzt.docs/0_de+docs/1_en+ EN-Spiegel aktualisiert.Nachbesserungen aus Review (iterativ)
ResolveCsCoreAssembly,TryResolveAssemblyFromDirectory,TryLoadAssemblyFromPath, Tuple-Reader).Security- und Merge-Gates
security/code-scanning/tools: 0 offene Alerts als Merge-Bedingung.SECURITY.md.Evidence (auditierbar)
dotnet test /Users/tomwerner/RiderProjects/FileClassifier/tests/FileTypeDetectionLib.Tests/FileTypeDetectionLib.Tests.csproj -c Release -v minimal560 passed, 0 failed.bash /Users/tomwerner/RiderProjects/FileClassifier/tools/ci/bin/run.sh preflight0.bash /Users/tomwerner/RiderProjects/FileClassifier/tools/ci/bin/run.sh tests-bdd-coverage0.bash /Users/tomwerner/RiderProjects/FileClassifier/tools/ci/bin/run.sh api-contract0.DoD (mindestens 2 pro Punkt)
/Users/tomwerner/RiderProjects/FileClassifier/src/FileTypeDetection/Infrastructure/Utils/CsCoreRuntimeBridge.vbvorhanden560/560) inkl. neuer Randfallpfade<b>/<br/>nur an relevanten Hover-Stellen ergänzt/Users/tomwerner/RiderProjects/FileClassifier/tests/FileTypeDetectionLib.Tests/Unit/CsCoreUtilityBridgeUnitTests.csvorhandenapi-contract+tests-bdd-coveragelokal grün6.1.17Directory.Build.props+FileTypeDetectionLib.vbprojauf6.1.17Nicht-Ziele: keine Major-Upgrades, keine Umsetzung separater Issues
#121/#122/#123.