Implemented dynamic load list of models with caching#9
Open
s2005 wants to merge 4 commits intotonybaloney:mainfrom
Open
Implemented dynamic load list of models with caching#9s2005 wants to merge 4 commits intotonybaloney:mainfrom
s2005 wants to merge 4 commits intotonybaloney:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
llm_github_models.py:51
- [nitpick] The class name GitHubModelsConfig is too generic. Consider renaming it to something more specific like GitHubModelsFetchConfig.
class GitHubModelsConfig(BaseModel):
llm_github_models.py:87
- Ensure that the new dynamic fetching logic in fetch_models is covered by tests.
def fetch_models() -> List[Tuple[str, bool, List[str], List[str]]]:
Owner
|
sorry I made some big changes so you'll need to rebase. I've been asking the team behind this about a better API and apparently one is coming, that should include the parameters and whether the model supports streaming. So I think it's best to wait to implement some dynamic fetching. |
Author
|
np |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.