Conversation
Contributor
There was a problem hiding this comment.
Looks great!
Just a few nitpicks to not forget:
- Since at the moment labcore is not in pypi, we should say to install using the
-eflag from a local clone. One the linding page as well - Mention that the
Fitclass is a thin wrapper to the lmfit package which is the one that is actually doing the fitting. - a small section on DataDicts would be nice.
- We should clean the output of the last cells that say they cannot save a fit result or something like that. We should probably handle that better
marcosfrenkel
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 15 minute guide for labcore, cleaning up the home page for labcore docs too