Skip to content

V4 changes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThomasKranitsas merged 31 commits into from
Nov 28, 2018
Merged

V4 changes #30

ThomasKranitsas merged 31 commits into from
Nov 28, 2018

Conversation

@sushilshinde
Copy link
Collaborator

@sushilshinde sushilshinde commented Nov 28, 2018

@ThomasKranitsas, please review

a-lowe and others added 30 commits June 28, 2018 10:51
@a-lowe
Adds support for v4 API and updates challenge service to use it.
31e84ed
@a-lowe
Updates getUserChallenges to use v4.
156381b
@a-lowe
Merge branch 'master' into new-develop-mm
c65af46
@a-lowe
Fixes issues with track being null and TCO events not displaying on e…
ba0098e 
…ligible challenges.
@birdofpreyru
Adds "prepack" script
81a0e8b
@birdofpreyru
Allows "-rcXXX" suffix on release tags
9379580
@birdofpreyru
Fix previous commit
d2b3912
@birdofpreyru
Another fix
aa1bc0c
@birdofpreyru
Update of release config
7581820
@a-lowe
Adds delay to challenge refresh on register/unregister to allow time …
bffd66c 
…for API to update.
@birdofpreyru
Merge branch 'develop' into new-develop-mm
0c39928
@a-lowe
Adds challenge normalizations for legacy Marathon Matches. Fixes sort…
405ec60 
…ing for new MMs.
@a-lowe
Update package lock.
709de69
@a-lowe
Update version.
af28491
@birdofpreyru
Merge branch 'develop' into new-develop-mm
8f45e42
@sushilshinde
After merge
bb6b247
@sushilshinde
fixing build issues
fabce7b
@sushilshinde
fixing build issues
52f94bb
@sushilshinde
Merge pull request #28 from sushilshinde/new-develop-mm
3c914fe 
New develop mm
@sushilshinde
pushing build artifact - this is for testing only
f05e63e
@sushilshinde
deleting prod build artifacts
14646af
issue_1732 fixed linting issues
e0250be
@sushilshinde
Merge pull request #29 from rashmi73/issue_1732
d6f3edb 
issue_1732 fixed linting issues
@sushilshinde
adding prod dist - for testign only
ef07dd6
@sushilshinde
deleting prod dist
bc45c27
@sushilshinde
removing hardcoding
54b5b14
@sushilshinde
building dev dist
3e32332
@sushilshinde
adding prod folder
c761a65
@sushilshinde
Changed npm version
726db44
@sushilshinde
Deleting dist folder, updating gitignore
1e4b154
ThomasKranitsas
ThomasKranitsas suggested changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@ThomasKranitsas ThomasKranitsas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my code review:

In https://github.com/topcoder-platform/topcoder-react-lib/blob/1e4b154636c86c111b964c0258e6a6706735cf1a/src/services/challenges.js

  1. There are many typos v3 => v4 (in method documentation).
  2. I see that we use the getApiResponsePayloadV3() method with the response from the V4. I'm not sure if that's correct.
  3. getApiV3 is defined but never used.
  4. Not sure why we defined both this.private.api and this.private.apiV4 as getApiV4(tokenV3). This is confusing.

@ThomasKranitsas ThomasKranitsas merged commit 626aa51 into develop Nov 28, 2018
@ThomasKranitsas ThomasKranitsas mentioned this pull request Dec 13, 2018
Closed
5 tasks
@sushilshinde sushilshinde deleted the new-develop-mm branch September 26, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ThomasKranitsas ThomasKranitsas ThomasKranitsas requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sushilshinde @ThomasKranitsas @a-lowe @birdofpreyru