Revert " Adding table input support for batched SparseLinear, implementing gradInput correctly, fixing other bugs"#723
Closed
zhangxiangxiao wants to merge 1 commit intotorch:masterfrom
Conversation
…nting gradInput correctly, fixing other bugs"
Member
|
see my comments on the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #698
The new SparseLinear module breaks projects in non-batch mode that depends on the fast implementation of updateParameters using self.lastInput. It includes some implementations of memory networks, word embedding and ranking models with HogWILD parallelization. See the comment to the original pull request.