Conversation
zerolab
left a comment
There was a problem hiding this comment.
The changes themselves look good.
Made a suggestion to do a bit of tidy up while at it (Drop Django < 4.2, Python < 3.9)
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
|
Thanks @zerolab — I've added this change. I'm not sure where you mean to drop Python 3.8 — I think Django 4.2 still supports Py3.8. I did drop Django3.2 from the tox dependencies. |
|
While Django 4.2 still supports it, Python 3.8 is no longer maintained - https://endoflife.date/python - so this is a good time to drop it |
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
|
Thanks @zerolab - I also cleaned up some of the GitHub workflow to remove references to the removed toxenvs and updated the docs. |
|
Thank you @mark-meyer. a couple of more things then this is good to go 🙌🏼 |
Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
…imental. Co-authored-by: Dan Braghiș <31622+zerolab@users.noreply.github.com>
zerolab
left a comment
There was a problem hiding this comment.
LGTM.
Will leave the tests to run. Hopefully we can make a new release tomorrow (as it is end of the day for me, at least)
|
Hi @zerolab Is there anything blocking this being released now? |
|
Unfortunately I do not have the power to make a release. |
|
@thibaudcolas Would you able to make a release? |
|
Hey @thibaudcolas and @zerolab, when will it be released? |
|
Oh sorry all, we discussed this internally but I didn’t realise so many people were waiting on it. I’ll get on with the release today. @zerolab as far as I can see you, me, @alxbridge all have release permissions? Let’s check some time (and set up Trusted Publishing). |
|
…aaand we’re live! v1.3.0 is now out. All working great as far as I can tell :) |
Description
Please include a summary of the changes and which issue this relates to (if applicable).
Fixes # (issue)
Updates project to support Django 5.1
Checklist