Skip to content

Conversation

@arch1995
Copy link
Contributor

@arch1995 arch1995 commented Mar 10, 2025

Motivation and Context

This PR aims to simplify the social logins and simplify the SDK methods and usage.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4440

Description

  • Enables social login popup handler.
  • Refactor triggerLogin method to support single and grouped connections.
  • Remove aggregate login methods and corresponding types.
  • Use new bc redundant adaptive handler.
  • Rename types from
    • typeOfLogin -> authConnection.
    • verifier -> authConnectionId.
    • aggregateVerifier -> groupedConnectionId.
    • verifierId -> userId.
    • verifierIdField -> userIdField
    • isVerifierIdCaseSensitive -> isUserIdCaseSensitive.

How has this been tested?

QA and Devrels tested this.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arch1995 arch1995 marked this pull request as draft March 10, 2025 18:05
@arch1995 arch1995 self-assigned this Mar 10, 2025
@arch1995 arch1995 requested a review from chaitanyapotti March 10, 2025 18:05
@arch1995 arch1995 marked this pull request as ready for review March 12, 2025 17:39
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 81c7560 into master Mar 13, 2025
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/enable-social-login branch March 13, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants