Skip to content

net/bridge: fix dropping packets that moving through bridge interface #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hexta wants to merge 1 commit into from
Closed

net/bridge: fix dropping packets that moving through bridge interface #370

Hexta wants to merge 1 commit into from

Conversation

@Hexta
Copy link
Contributor

@Hexta Hexta commented Dec 30, 2016

Fix regression introduced by commit c5136b1.
br_nf_pre_routing_finish() calls itself instead of
br_nf_pre_routing_finish_bridge().

Due to this bug reverse path filter drops packets that moving through bridge interface.

net/bridge: fix dropping packets that moving through bridge interface
01c672b 
Fix regression introduced by commit c5136b1.
br_nf_pre_routing_finish() calls itself instead of
br_nf_pre_routing_finish_bridge().

Due to this bug reverse path filter drops packets that moving through bridge interface.
@Hexta
Copy link
Contributor Author

Hexta commented Jan 10, 2017

Close since it was fixed by 14221cc

@Hexta Hexta closed this Jan 10, 2017
fengguang pushed a commit to 0day-ci/linux that referenced this pull request Jun 8, 2017
@edumazet
ipv4: igmp: fix a use after free
20beeb1 
Andrey reported a use-after-free in add_grec(), courtesy of syzkaller.

Problem here is that igmp_stop_timer() uses a del_timer(), so we can not
guarantee that another cpu is not servicing the timer.

Therefore, if igmp_group_dropped() call from ip_mc_dec_group() is
immediately followed by ip_mc_clear_src(), ip_mc_clear_src() might free
memory that could be used by the other cpu servicing the timer.

To fix this issue, we should defer the memory freeing
(ip_mc_clear_src()) to the point all references to (struct
ip_mc_list)->refcnt have been released.
This happens in ip_ma_put()

==================================================================
BUG: KASAN: use-after-free in add_grec+0x101e/0x1090 net/ipv4/igmp.c:473
Read of size 8 at addr ffff88003053c1a0 by task swapper/0/0

CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.12.0-rc3+ torvalds#370
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:16 [inline]
 dump_stack+0x292/0x395 lib/dump_stack.c:52
 print_address_description+0x73/0x280 mm/kasan/report.c:252
 kasan_report_error mm/kasan/report.c:351 [inline]
 kasan_report+0x22b/0x340 mm/kasan/report.c:408
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:429
 add_grec+0x101e/0x1090 net/ipv4/igmp.c:473
 igmpv3_send_cr net/ipv4/igmp.c:663 [inline]
 igmp_ifc_timer_expire+0x46d/0xa80 net/ipv4/igmp.c:768
IPVS: length: 51 != 8
 call_timer_fn+0x23f/0x800 kernel/time/timer.c:1268
 expire_timers kernel/time/timer.c:1307 [inline]
 __run_timers+0x94e/0xcd0 kernel/time/timer.c:1601
 run_timer_softirq+0x21/0x80 kernel/time/timer.c:1614
 __do_softirq+0x2fb/0xb99 kernel/softirq.c:284
 invoke_softirq kernel/softirq.c:364 [inline]
 irq_exit+0x19e/0x1d0 kernel/softirq.c:405
 exiting_irq arch/x86/include/asm/apic.h:652 [inline]
 smp_apic_timer_interrupt+0x76/0xa0 arch/x86/kernel/apic/apic.c:966
 apic_timer_interrupt+0x93/0xa0 arch/x86/entry/entry_64.S:481
RIP: 0010:native_safe_halt+0x6/0x10 arch/x86/include/asm/irqflags.h:53
RSP: 0018:ffffffff85a079a8 EFLAGS: 00000282 ORIG_RAX: ffffffffffffff10
RAX: dffffc0000000020 RBX: 1ffffffff0b40f38 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffffffff85a2a9e4
RBP: ffffffff85a079a8 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: dffffc0000000000
R13: ffffffff85a07a60 R14: ffffffff86171338 R15: 1ffffffff0b40f5b
 </IRQ>
 arch_safe_halt arch/x86/include/asm/paravirt.h:98 [inline]
 default_idle+0x8f/0x440 arch/x86/kernel/process.c:341
 arch_cpu_idle+0xa/0x10 arch/x86/kernel/process.c:332
 default_idle_call+0x36/0x60 kernel/sched/idle.c:98
 cpuidle_idle_call kernel/sched/idle.c:156 [inline]
 do_idle+0x348/0x420 kernel/sched/idle.c:245
 cpu_startup_entry+0x18/0x20 kernel/sched/idle.c:350
 rest_init+0x18d/0x1a0 init/main.c:415
 start_kernel+0x747/0x779 init/main.c:679
 x86_64_start_reservations+0x2a/0x2c arch/x86/kernel/head64.c:196
 x86_64_start_kernel+0x132/0x141 arch/x86/kernel/head64.c:177
 secondary_startup_64+0x9f/0x9f arch/x86/kernel/head_64.S:304

Allocated by task 30543:
 save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
 save_stack+0x43/0xd0 mm/kasan/kasan.c:513
 set_track mm/kasan/kasan.c:525 [inline]
 kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:617
 kmem_cache_alloc_trace+0x82/0x270 mm/slub.c:2745
 kmalloc include/linux/slab.h:492 [inline]
 kzalloc include/linux/slab.h:665 [inline]
 ip_mc_add1_src net/ipv4/igmp.c:1909 [inline]
 ip_mc_add_src+0x6cd/0x1020 net/ipv4/igmp.c:2033
 ip_mc_msfilter+0x5e5/0xcf0 net/ipv4/igmp.c:2403
 do_ip_setsockopt.isra.12+0x2d47/0x38c0 net/ipv4/ip_sockglue.c:959
 ip_setsockopt+0x3a/0xb0 net/ipv4/ip_sockglue.c:1256
 tcp_setsockopt+0x82/0xd0 net/ipv4/tcp.c:2740
 sock_common_setsockopt+0x95/0xd0 net/core/sock.c:2844
 SYSC_setsockopt net/socket.c:1798 [inline]
 SyS_setsockopt+0x270/0x3a0 net/socket.c:1777
 entry_SYSCALL_64_fastpath+0x1f/0xbe

Freed by task 30543:
 save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
 save_stack+0x43/0xd0 mm/kasan/kasan.c:513
 set_track mm/kasan/kasan.c:525 [inline]
 kasan_slab_free+0x72/0xc0 mm/kasan/kasan.c:590
 slab_free_hook mm/slub.c:1357 [inline]
 slab_free_freelist_hook mm/slub.c:1379 [inline]
 slab_free mm/slub.c:2961 [inline]
 kfree+0xe8/0x2b0 mm/slub.c:3882
 ip_mc_clear_src+0x69/0x1c0 net/ipv4/igmp.c:2078
 ip_mc_dec_group+0x19a/0x470 net/ipv4/igmp.c:1618
 ip_mc_drop_socket+0x145/0x230 net/ipv4/igmp.c:2609
 inet_release+0x4e/0x1c0 net/ipv4/af_inet.c:411
 sock_release+0x8d/0x1e0 net/socket.c:597
 sock_close+0x16/0x20 net/socket.c:1072
 __fput+0x332/0x7f0 fs/file_table.c:209
 ____fput+0x15/0x20 fs/file_table.c:245
 task_work_run+0x19b/0x270 kernel/task_work.c:116
 exit_task_work include/linux/task_work.h:21 [inline]
 do_exit+0x18a3/0x2820 kernel/exit.c:878
 do_group_exit+0x149/0x420 kernel/exit.c:982
 get_signal+0x76d/0x1790 kernel/signal.c:2318
 do_signal+0xd2/0x2130 arch/x86/kernel/signal.c:808
 exit_to_usermode_loop+0x17a/0x210 arch/x86/entry/common.c:157
 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline]
 syscall_return_slowpath+0x3ba/0x410 arch/x86/entry/common.c:263
 entry_SYSCALL_64_fastpath+0xbc/0xbe

The buggy address belongs to the object at ffff88003053c1a0
 which belongs to the cache kmalloc-64 of size 64
The buggy address is located 0 bytes inside of
 64-byte region [ffff88003053c1a0, ffff88003053c1e0)
The buggy address belongs to the page:
page:ffffea0000c14f00 count:1 mapcount:0 mapping:          (null)
index:0x0 compound_mapcount: 0
flags: 0x100000000008100(slab|head)
raw: 0100000000008100 0000000000000000 0000000000000000 0000000100140014
raw: ffffea0000c2f520 ffffea0000e20aa0 ffff88003e80f740 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88003053c080: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88003053c100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88003053c180: fc fc fc fc fb fb fb fb fb fb fb fb fc fc fc fc
                               ^
 ffff88003053c200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88003053c280: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
tobetter pushed a commit to tobetter/linux that referenced this pull request Apr 8, 2019
@mdrjr
Merge pull request torvalds#370 from Owersun/odroidn2-4.9.y
ca7a857 
AML: Backport 3.14 patch for video, seriously improving video playback
nbdd0121 pushed a commit to nbdd0121/linux that referenced this pull request Jun 10, 2021
@ojeda
Merge pull request torvalds#370 from ojeda/sync
5dd07d5 
Sync with v5.13-rc5
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Dec 7, 2022
@LiBaokun96 @tytso
ext4: fix use-after-free in ext4_orphan_cleanup
ad7ab3c 
I caught a issue as follows:
==================================================================
 BUG: KASAN: use-after-free in __list_add_valid+0x28/0x1a0
 Read of size 8 at addr ffff88814b13f378 by task mount/710

 CPU: 1 PID: 710 Comm: mount Not tainted 6.1.0-rc3-next torvalds#370
 Call Trace:
  <TASK>
  dump_stack_lvl+0x73/0x9f
  print_report+0x25d/0x759
  kasan_report+0xc0/0x120
  __asan_load8+0x99/0x140
  __list_add_valid+0x28/0x1a0
  ext4_orphan_cleanup+0x564/0x9d0 [ext4]
  __ext4_fill_super+0x48e2/0x5300 [ext4]
  ext4_fill_super+0x19f/0x3a0 [ext4]
  get_tree_bdev+0x27b/0x450
  ext4_get_tree+0x19/0x30 [ext4]
  vfs_get_tree+0x49/0x150
  path_mount+0xaae/0x1350
  do_mount+0xe2/0x110
  __x64_sys_mount+0xf0/0x190
  do_syscall_64+0x35/0x80
  entry_SYSCALL_64_after_hwframe+0x63/0xcd
  </TASK>
 [...]
==================================================================

Above issue may happen as follows:
-------------------------------------
ext4_fill_super
  ext4_orphan_cleanup
   --- loop1: assume last_orphan is 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan)
    ext4_truncate --> return 0
      ext4_inode_attach_jinode --> return -ENOMEM
    iput(inode) --> free inode<12>
   --- loop2: last_orphan is still 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan);
    // use inode<12> and trigger UAF

To solve this issue, we need to propagate the return value of
ext4_inode_attach_jinode() appropriately.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221102080633.1630225-1-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
torvalds pushed a commit that referenced this pull request Dec 13, 2022
@LiBaokun96 @tytso
ext4: fix use-after-free in ext4_orphan_cleanup
a71248b 
I caught a issue as follows:
==================================================================
 BUG: KASAN: use-after-free in __list_add_valid+0x28/0x1a0
 Read of size 8 at addr ffff88814b13f378 by task mount/710

 CPU: 1 PID: 710 Comm: mount Not tainted 6.1.0-rc3-next #370
 Call Trace:
  <TASK>
  dump_stack_lvl+0x73/0x9f
  print_report+0x25d/0x759
  kasan_report+0xc0/0x120
  __asan_load8+0x99/0x140
  __list_add_valid+0x28/0x1a0
  ext4_orphan_cleanup+0x564/0x9d0 [ext4]
  __ext4_fill_super+0x48e2/0x5300 [ext4]
  ext4_fill_super+0x19f/0x3a0 [ext4]
  get_tree_bdev+0x27b/0x450
  ext4_get_tree+0x19/0x30 [ext4]
  vfs_get_tree+0x49/0x150
  path_mount+0xaae/0x1350
  do_mount+0xe2/0x110
  __x64_sys_mount+0xf0/0x190
  do_syscall_64+0x35/0x80
  entry_SYSCALL_64_after_hwframe+0x63/0xcd
  </TASK>
 [...]
==================================================================

Above issue may happen as follows:
-------------------------------------
ext4_fill_super
  ext4_orphan_cleanup
   --- loop1: assume last_orphan is 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan)
    ext4_truncate --> return 0
      ext4_inode_attach_jinode --> return -ENOMEM
    iput(inode) --> free inode<12>
   --- loop2: last_orphan is still 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan);
    // use inode<12> and trigger UAF

To solve this issue, we need to propagate the return value of
ext4_inode_attach_jinode() appropriately.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221102080633.1630225-1-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
beakthoven pushed a commit to Neutron-Projects/kernel-dejavu that referenced this pull request Dec 30, 2022
@LiBaokun96 @beakthoven
ext4: fix use-after-free in ext4_orphan_cleanup
f242c8e 
I caught a issue as follows:
==================================================================
 BUG: KASAN: use-after-free in __list_add_valid+0x28/0x1a0
 Read of size 8 at addr ffff88814b13f378 by task mount/710

 CPU: 1 PID: 710 Comm: mount Not tainted 6.1.0-rc3-next torvalds#370
 Call Trace:
  <TASK>
  dump_stack_lvl+0x73/0x9f
  print_report+0x25d/0x759
  kasan_report+0xc0/0x120
  __asan_load8+0x99/0x140
  __list_add_valid+0x28/0x1a0
  ext4_orphan_cleanup+0x564/0x9d0 [ext4]
  __ext4_fill_super+0x48e2/0x5300 [ext4]
  ext4_fill_super+0x19f/0x3a0 [ext4]
  get_tree_bdev+0x27b/0x450
  ext4_get_tree+0x19/0x30 [ext4]
  vfs_get_tree+0x49/0x150
  path_mount+0xaae/0x1350
  do_mount+0xe2/0x110
  __x64_sys_mount+0xf0/0x190
  do_syscall_64+0x35/0x80
  entry_SYSCALL_64_after_hwframe+0x63/0xcd
  </TASK>
 [...]
==================================================================

Above issue may happen as follows:
-------------------------------------
ext4_fill_super
  ext4_orphan_cleanup
   --- loop1: assume last_orphan is 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan)
    ext4_truncate --> return 0
      ext4_inode_attach_jinode --> return -ENOMEM
    iput(inode) --> free inode<12>
   --- loop2: last_orphan is still 12 ---
    list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan);
    // use inode<12> and trigger UAF

To solve this issue, we need to propagate the return value of
ext4_inode_attach_jinode() appropriately.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221102080633.1630225-1-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Sep 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
a71fece 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Sep 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
0f72656 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 1, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
0fece18 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 10, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
e9466d3 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 11, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
7291bf9 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 15, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
b28220c 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 20, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
a43c2c4 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 21, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
acbb985 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 21, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
db96cb4 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 21, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
62504db 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
127a1ec 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
4877d01 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
bc5ba64 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
49375ab 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 27, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
f7d38b8 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 28, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
dbf37e7 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Oct 30, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
5627592 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 3, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
31e35bb 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 5, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
3240073 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 5, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
d230890 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 7, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
d291ca1 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 15, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
445d165 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 16, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
e672d67 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 20, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
bba434f 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 22, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
f625538 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 23, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
7b24a65 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 23, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
b81597a 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 23, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
5c2eebb 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 25, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
c988d30 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
guidosarducci added a commit to guidosarducci/linux that referenced this pull request Nov 26, 2025
@guidosarducci
selftest/bpf: Fix snprintf test on 32-bit
6215414 
Test snprintf/snprintf_positive exercises BPF_SNPRINTF() and currently
fails on armhf:

root@qemu-armhf:/usr/libexec/kselftests-bpf# ./test_progs -a snprintf
[...]
test_snprintf_positive:FAIL:addr_out unexpected error: -16 (errno 0)
test_snprintf_positive:FAIL:addr_ret unexpected addr_ret: actual 27 != expected 51
[...]
torvalds#370/1   snprintf/snprintf_positive:FAIL

This happens because the expected string is hard-coded to assume 64-bit
pointer usage and thus fails on 32-bit armhf. Make the test portable by
generating the expected string at runtime to account for the native pointer
size and formatting width.

Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hexta