Conversation
…e old options - Updated dependencies for @tanstack/react-query and related packages to version 4.40.0 in pnpm-lock.yaml and pnpm-workspace.yaml. - Adjusted peer dependencies in package.json to reflect the new version. - Deprecated certain options and types in the react-query-4 package to align with the latest API changes. - Updated tests to accommodate changes in type expectations and removed unused imports. Co-authored-by: halfstack <61955474+ha1fstack@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 9d2e076 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
People can be co-author:
|
Contributor
|
Size Change: -1.05 kB (-1.65%) Total Size: 62.8 kB
ℹ️ View Unchanged
|
… usePrefetchQuery tests - Changed import statements in PrefetchQuery.test-d.tsx and usePrefetchQuery.test-d.tsx to source queryOptions from @tanstack/react-query instead of local files. - This aligns the tests with the updated package structure following the recent dependency updates.
…tack/react-query - Removed the local import of queryOptions and replaced it with the import from @tanstack/react-query to ensure consistency with the updated package structure.
manudeli
changed the title
manudeli
changed the title
manudeli
changed the title
manudeli
commented
Jun 30, 2025
gwansikk
approved these changes
Jun 30, 2025
Collaborator
gwansikk
left a comment
gwansikk
left a comment
There was a problem hiding this comment.
The day has finally come when it is officially supported. It's a historic day. 그동안의 여정의 결과, 멋있습니다. 계속 킵고잉하시죠!! Suspensive!
Comment on lines
+68
to
+69
| * @deprecated Use `queryOptions` from \@tanstack/react-query@^4.40.0 | ||
| * @example |
Collaborator
There was a problem hiding this comment.
Suggested change
| * @deprecated Use `queryOptions` from \@tanstack/react-query@^4.40.0 | |
| * @example | |
| * @deprecated Use `queryOptions` from \@tanstack/react-query@^4.40.0 | |
| * @see (If a migration guide becomes available later.) | |
| * @example |
this is a suggestion
ha1fstack
approved these changes
Jul 1, 2025
Contributor
ha1fstack
left a comment
ha1fstack
left a comment
There was a problem hiding this comment.
Amazing work as always, thank you for prompt update!
Comment on lines
+67
to
+90
| const [ | ||
| query1, | ||
| query2, | ||
| // query3 | ||
| ] = useQueries({ | ||
| queries: [ | ||
| query.options1(), | ||
| { ...query.options2() }, | ||
| queryOptions({ | ||
| queryKey: [...queryKey, 4] as const, | ||
| queryFn: () => Promise.resolve({ field: 'success' }), | ||
| select: (data) => { | ||
| expectTypeOf(data).toEqualTypeOf<{ field: string }>() | ||
| return data.field | ||
| }, | ||
| }), | ||
| // queryOptions({ | ||
| // queryKey: [...queryKey, 4] as const, | ||
| // queryFn: () => Promise.resolve({ field: 'success' }), | ||
| // select: (data) => { | ||
| // expectTypeOf(data).toEqualTypeOf<{ field: string }>() | ||
| // return data.field | ||
| // }, | ||
| // }), | ||
| ], | ||
| }) | ||
| expectTypeOf(query1).toEqualTypeOf<UseQueryResult<{ field: string }>>() | ||
| expectTypeOf(query1.data).toEqualTypeOf<{ field: string } | undefined>() | ||
| expectTypeOf(query2).toEqualTypeOf<UseQueryResult<{ field: string }>>() | ||
| expectTypeOf(query2.data).toEqualTypeOf<{ field: string } | undefined>() | ||
| expectTypeOf(query3).toEqualTypeOf<UseQueryResult<string>>() | ||
| expectTypeOf(query3.data).toEqualTypeOf<string | undefined>() | ||
| // expectTypeOf(query3).toEqualTypeOf<UseQueryResult<string>>() | ||
| // expectTypeOf(query3.data).toEqualTypeOf<string | undefined>() |
Contributor
There was a problem hiding this comment.
Any reason for commenting out instead of removing it?
Member
Author
There was a problem hiding this comment.
There was problem already before
It's because of @tanstack/react-query v4's useQueries type fault. I'll fix it in TanStack v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeerDep @tanstack/react-query to version 4.40.0 and deprecate old options
@ha1fstack (issue reporter), could you review these changes, please?
Next thing to do: TanStack/query#9334
After several years of polishing the Suspensive React Query interface — from raising the first issue to this PR and finally merging into TanStack Query v4 — it feels like we’re nearing the end of a long journey of Suspensive React Query. 감성적이게 되는 날입니다 🥲
PR Checklist