Conditionalize short sequences with same branch target#346
Merged
totalspectrum merged 1 commit intototalspectrum:masterfrom Jan 17, 2023
Merged
Conditionalize short sequences with same branch target#346totalspectrum merged 1 commit intototalspectrum:masterfrom
totalspectrum merged 1 commit intototalspectrum:masterfrom
Conversation
Contributor
Author
|
Potential downside to current impl: Could cause loss of speed if more than one op becomes conditional. Though currently seemingly offset by the benefit of other passes being able to better deal with the code. Obviously always a size saving. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deals with multiple branches going the same place. If possible, it now just conditionalizes over the second condition.
Really nice and short change.