fix: use mem::swap on cloned inner service #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomharmon
force-pushed
the
fix/auth-clone-issue
branch
from
cc5107a to
5c769b5
Compare
jplatte
reviewed
Apr 24, 2025
tomharmon
force-pushed
the
fix/auth-clone-issue
branch
from
5c769b5 to
72670ea
Compare
In the `AsyncRequireAuthorization` service, the cloned service could be different than the ready service due to the complexities described here: https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services so this commit fixes it by using std::mem::replace as recommended in the documentation
tomharmon
force-pushed
the
fix/auth-clone-issue
branch
from
72670ea to
a5226e9
Compare
tomharmon
changed the title
jplatte
approved these changes
Apr 24, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Without this change the inner service may
panic!since the cloned service may not be the ready service as described inthe tower docs
Solution
Use
std::mem::replaceto swap the ready and cloned services