feat(redirect): Removed headers after empty payload set.
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 1, 2025
jplatte
reviewed
Jun 1, 2025
seanmonstar
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This patch removed the
content-type,content-length,content-encoding,transfer-encodingheaders in the follow_redirect::poll after the responsebodyis set to empty. This logic works well inreqwest.Currently, the follow_redirect::poll doesn't remove these
headerafter redirecting, this behavior is a violation of the HTTP/1.1 specAlso see seanmonstar/reqwest#2705
Solution
Remove the headers before making redirection