-
Notifications
You must be signed in to change notification settings - Fork 216
Add support for custom status code in TimeoutLayer #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom status code in TimeoutLayer #599
Conversation
jplatte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
|
Hi @jplatte, sorry to ping you, but would you be able to check this PR again? I would like to use this feature soon :) |
|
Always fine to ping me after a week or two of inactivity :) |
jplatte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! Do you need this in a release?
|
Thanks for the review :) a release would be cool, since we can get rid of some custom code, but it's not urgent |
|
I don't understand why the deprecation of the |
|
I don't think HTTP |
Motivation
Timeoutmiddleware to return HTTP503 Service Unavailablestatus code #579 (comment)TimeoutLayermiddleware allow returning other status codes? #300Solution
TimeoutLayer::newas deprecated