service: Clarify subtly around cloning and readiness #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
May 5, 2021
Member
LucioFranco
left a comment
LucioFranco
left a comment
There was a problem hiding this comment.
Yeah, good catch and we should add this. We may also want to add it to the possible lists of panic that if you clone and don't poll ready that instance then it could panic. We could also ensure that our tower-test mock service covers this, we already do this somewhat but I don't remember if it catches this specific case.
Member
Author
Thats a good idea. I'll look into that. |
hawkw
added a commit
that referenced
this pull request
Jun 17, 2022
|
The examples here don't seem to call |
Member
|
Yeah, they should for sure be calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sections to the
Servicedocs that mentions the subtlety around cloning services and readiness.