util: Adds a BoxCloneServiceLayer #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This layer is similar to a BoxLayer, but produces a BoxCloneService instead, so can be used when the underlying layers must be clone.
davidpdrsn
reviewed
Nov 1, 2022
Member
davidpdrsn
left a comment
davidpdrsn
left a comment
There was a problem hiding this comment.
I agree this seems useful but I'm not a fan of the name BoxCloneLayer. It sounds like the layer is Clone but in fact it's the service it produces that is Clone.
BoxLayer is already Clone.
Member
|
Should we name it CloneBoxLayer? |
Contributor
Author
|
Happy for whatever name you want. I will clarify in the docs for this type that BoxLayer is already clone, but that the services it produces are not clone. |
Member
|
yeah I like that BoxCloneServiceLayer since that matches what https://docs.rs/tower/latest/tower/util/struct.BoxCloneService.html is named as well. |
LucioFranco
approved these changes
Nov 3, 2022
LucioFranco
changed the title
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This layer is similar to a BoxLayer, but produces a BoxCloneService instead, so can be used when the underlying layers must be clone.
Resolves #707