Upgrade to indexmap v2 (MSRV 1.63) #741
Conversation
|
|
||
| /// Obtains a mutable reference to a service in the ready set by index. | ||
| pub fn get_ready_index_mut(&mut self, idx: usize) -> Option<(&mut K, &mut S)> { | ||
| pub fn get_ready_index_mut(&mut self, idx: usize) -> Option<(&K, &mut S)> { |
There was a problem hiding this comment.
This is a breaking change, so I suppose it should go on your 0.5 milestone. But if you really want the mutable key, there's an opt-in by using the MutableKeys trait and its get_index_mut2 method.
There was a problem hiding this comment.
It's feels like more of a footgun to have the key be mutable, given the warnings mentioned in MutableKeys::get_index_mut2... and there's really nothing in the original PR or docs that speaks specifically to the key needing to be mutable... so I think this is a worthwhile change to make given that changing the MSRV is breaking anyways.
cuviper
changed the title
|
We were later able to relax |
|
As a result, the latest version of tower no longer builds on Rust nightly This PR should fix that problem |
I'm not sure what you're seeing, but |
You're right, I wasn't precise. Pulling in tower by itself with no other crates, even with It seems some other crate in our workspace is turning on the So in that case, bumping indexmap to v2 on tower probably wouldn't help out since there is some other crate somewhere depending on it and turning on the feature. Apologies for the confusion here. |
|
OK -- |
|
|
||
| /// Obtains a mutable reference to a service in the ready set by index. | ||
| pub fn get_ready_index_mut(&mut self, idx: usize) -> Option<(&mut K, &mut S)> { | ||
| pub fn get_ready_index_mut(&mut self, idx: usize) -> Option<(&K, &mut S)> { |
There was a problem hiding this comment.
It's feels like more of a footgun to have the key be mutable, given the warnings mentioned in MutableKeys::get_index_mut2... and there's really nothing in the original PR or docs that speaks specifically to the key needing to be mutable... so I think this is a worthwhile change to make given that changing the MSRV is breaking anyways.
tobz
added
A-ready-cache
tobz
added
the
S-awaiting-release
|
This has been released as part of Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
3 participants
No description provided.