feat: Make new functions const when possible #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerkmann
force-pushed
the
add-const-keyword
branch
from
bd5db7f to
d8dd352
Compare
The main reason was to allow to initialize the RateLimitLayer in a const context. So why not making ever new function const (wherever it's possible). :P
kerkmann
force-pushed
the
add-const-keyword
branch
from
d8dd352 to
a270cd5
Compare
tobz
approved these changes
Jul 20, 2024
tobz
added
the
C-enhancement
Member
|
This is blocked on the MSRV, which would need to be at least 1.61 to support generic trait bounds on const functions. Parking for now. |
tobz
added
the
S-blocked
tobz
added
relnotes
Member
|
This has been released as part of Thanks again for your contribution! |
tobz
removed
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason was to allow to initialize the RateLimitLayer in a const context. So why not making ever new function const (wherever it's possible). :P