Add type annotations#20
Merged
Merged
Conversation
gaborbernat
requested changes
Jul 17, 2021
Member
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
We should also type annotate the tests.
Comment on lines
+86
to
+92
| disallow_untyped_defs = True | ||
| disallow_incomplete_defs = True | ||
| check_untyped_defs = True | ||
| disallow_untyped_decorators = True | ||
| no_implicit_optional = True | ||
| disallow_subclassing_any = True | ||
| disallow_any_explicit = True |
Member
There was a problem hiding this comment.
I'd rather remove all this and mark the check strict.
| tox_env: | ||
| - dev | ||
| - pkg_check | ||
| - mypy |
Member
There was a problem hiding this comment.
let's call it type instead of mypy; it's a type check, mypy is an implementation detail
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 74.17% 82.12% +7.94%
==========================================
Files 3 6 +3
Lines 333 330 -3
Branches 71 72 +1
==========================================
+ Hits 247 271 +24
+ Misses 68 42 -26
+ Partials 18 17 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The registry lookup may return a non-string value, but it should always be a string for this particular key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8