feat: improve homebrew path detection #370
Merged
+50
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Aug 25, 2025
Member
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
Let's add test please to defend against regressions.
for more information, see https://pre-commit.ci
Contributor
Author
|
@gaborbernat Added some tests ! |
gaborbernat
approved these changes
Aug 26, 2025
luketainton
pushed a commit
to luketainton/repos_pypilot
that referenced
this pull request
Jan 5, 2026
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [platformdirs](https://github.com/tox-dev/platformdirs) ([changelog](https://github.com/tox-dev/platformdirs/releases)) | `==4.3.8` -> `==4.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/platformdirs (platformdirs)</summary> ### [`v4.4.0`](https://github.com/tox-dev/platformdirs/releases/tag/4.4.0) [Compare Source](tox-dev/platformdirs@4.3.8...4.4.0) ##### What's Changed - feat: improve homebrew path detection by [@​daeho-ro](https://github.com/daeho-ro) in [#​370](tox-dev/platformdirs#370) ##### New Contributors - [@​daeho-ro](https://github.com/daeho-ro) made their first contribution in [#​370](tox-dev/platformdirs#370) **Full Changelog**: <tox-dev/platformdirs@4.3.8...4.4.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44My4yIiwidXBkYXRlZEluVmVyIjoiNDEuODMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/366 Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk> Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve homebrew installed python detection.
This will detect the users that not only arm macos users but also intel macos users. And even if user change their homebrew prefix, this could catch them and use the path for that. I am not pretending to get the 100% users but just increase the chance of this.
Well, there is another option that just use HOMEBREW_PREFIX directly. But it depends on the user configuration and system so I didn't tried.
Here is my local output with homebrew installed python.