Add passCome68 strategy, helper, tests, and README example#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
placeSixEightUnlessPassOrComewhich removes newly-created place 6/8 bets when the pass point or existing come points already cover them.passCome68that composesminPassLineMaxOdds,minComeLineMaxOdds, andplaceSixEightUnlessPassOrCome, and exported it.minComeLineMaxOddsto usependingCountandpointCountand only create a pending come bet whenpendingCount === 0 && pointCount < maxComeBets, and added/renamed related wrapper functions.betting.test.jsvalidatingminComeLineMaxOddsbehavior,passCome68behavior (skipping place bets covered by pass or come), and updated exported function names; and added a README example CLI invocation ofpassCome68.Testing
npm testduring the earlier rollout and the TAP output shows all tests passing.minComeLineMaxOddsunit tests were added and passed, including a test ensuring only one pending come bet is created.passCome68unit tests were added and passed, covering pass odds, come pending bet, and skipped place bets behavior.Codex Task