Make an usleep after blocknotify recieved to prevent loosing blocks#240
Closed
opensourcerulez wants to merge 2 commits into
Closed
Make an usleep after blocknotify recieved to prevent loosing blocks#240opensourcerulez wants to merge 2 commits into
opensourcerulez wants to merge 2 commits into
Conversation
opensourcerulez
changed the title
Owner
|
hmm, doesnt seems useful... could be even worst. But maybe an optional delay could be set in the .conf |
Author
|
I saw it on many coins... i will make another commit later without delay - but now it can help not to loose blocks on fast coins where blocks cron searches too slow |
tpruvot
added a commit
that referenced
this pull request
Mar 12, 2018
tpruvot
added a commit
that referenced
this pull request
Mar 12, 2018
prevent job delays if no blocks were submitted double check coin id on blocknotify
Owner
|
see related PR #241, this one was reverted... |
Revasz
pushed a commit
to Revasz/yiimp
that referenced
this pull request
Mar 12, 2018
prevent job delays if no blocks were submitted double check coin id on blocknotify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent cases when wallet answers "ACCEPT" blockhash few ms after "BLOCKNOTIFY" and block is not stored in db...
You can play with number of MS in usleep to get minimal delay in you system...
Real example from logs:
16:58:37: notify: new block ZZZZZZZZ
16:58:37: *** ACCEPTED (diff 12345) by XXXX
(names were changed :D )