Merged
Conversation
mpozniak95
pushed a commit
to mpozniak95/openllmetry
that referenced
this pull request
May 24, 2024
Add sample redis rag application
nina-kollman
pushed a commit
that referenced
this pull request
Aug 11, 2025
nirga
added a commit
that referenced
this pull request
Aug 24, 2025
…vements 1. Fix trace_id/span_id type conversion across all instrumentations - Convert OpenTelemetry integer IDs to strings before upload calls - Standardize all signatures to use 4-parameter format consistently - Fix OpenAI config signature mismatch (was expecting 3 params, using 4) 2. Improve code readability (Issue #4 from PR review) - Extract helper methods to reduce complex nested if/else blocks - Use descriptive variable names (arg_index, content_item vs i, arg) - Apply consistent patterns across VertexAI and Google GenAI instrumentations - Maintain both async and sync versions with shared logic 3. Fix VertexAI ChatSession model name extraction - Add support for getting model name from ChatSession._model reference - Ensures send_message spans show correct model instead of "unknown" All changes maintain backward compatibility and pass linting checks. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
max-deygin-traceloop
added a commit
that referenced
this pull request
Mar 29, 2026
max-deygin-traceloop
added a commit
that referenced
this pull request
Mar 30, 2026
max-deygin-traceloop
added a commit
that referenced
this pull request
Mar 30, 2026
max-deygin-traceloop
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.