Skip to content

Comments

Add onnxruntime to a couple of nightly test runs.#133

Merged
arokem merged 2 commits intotractometry:mainfrom
arokem:more_onnx
Dec 21, 2025
Merged

Add onnxruntime to a couple of nightly test runs.#133
arokem merged 2 commits intotractometry:mainfrom
arokem:more_onnx

Conversation

@arokem
Copy link
Member

@arokem arokem commented Dec 21, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 21, 2025 15:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds onnxruntime support to nightly test workflows by including the "nn" extras dependency in pip install commands.

  • Adds "nn" extra to nightly_reco_test.yml and nightly_custom_test.yml workflows
  • Enables testing of onnxruntime functionality during nightly test runs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/nightly_reco_test.yml Adds "nn" extra to pip install command (contains typo: "plotm" instead of "plot")
.github/workflows/nightly_custom_test.yml Adds "nn" extra to pip install command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@arokem
Copy link
Member Author

arokem commented Dec 21, 2025

Looks like GitHub is throttling a few of our nightly tests, which may have become more demanding after the merge of #103. We should think about ways to mitigate that.

@arokem
Copy link
Member Author

arokem commented Dec 21, 2025

This is trivial, so I am going ahead and merge it so we get results tonight.

@arokem arokem merged commit e380b8c into tractometry:main Dec 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant