Merged
Conversation
Member
|
@staltz i thought i'd see you here eventually, after your visit to asyncstorage-down looks good, though u prob need a null check. exec() may return null, then exec(...)[1] will throw an error |
Contributor
Author
|
Oh right, sorry for that. Will fix. |
npm5 installs modules and changes their `package.json`::`version` field to be something like ``` "version": "https://registry.npmjs.org/rn-nodeify/-/rn-nodeify-7.0.1.tgz", ``` instead of ``` "version": "7.0.1", ``` This commit adds support for that first type of string but also supports npm4.
Contributor
Author
|
Updated the PR |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm5 installs modules and changes their
package.json::versionfield to be something likeinstead of
This commit adds support for that first type of string but also supports npm4.