Fix dual call issue with interactors with deferred after_performs#6
Merged
mjonas87 merged 1 commit intoforked-mainfrom Mar 28, 2024
Merged
Fix dual call issue with interactors with deferred after_performs#6mjonas87 merged 1 commit intoforked-mainfrom
mjonas87 merged 1 commit intoforked-mainfrom
Conversation
Jordan-Templeman
approved these changes
Mar 27, 2024
Jordan-Templeman
left a comment
Jordan-Templeman
left a comment
There was a problem hiding this comment.
🚀
The only thing I am noticing is there may need to be a newline here but I can not check into this branch so I can not confirm
Tristan-Trainual
left a comment
Tristan-Trainual
left a comment
There was a problem hiding this comment.
Couldn't find anything, just minor line space.
spec/integration/an_organizer_with_interactor_with_after_callbacks_deferred_spec.rb
Outdated
Show resolved
Hide resolved
mjonas87
force-pushed
the
fix-dual-call-issue
branch
from
1151baf to
69b8be6
Compare
jd-gray
reviewed
Mar 28, 2024
spec/integration/an_organizer_with_interactor_with_after_callbacks_deferred_spec.rb
Show resolved
Hide resolved
If an Interactor that has deferred after_performs is called from an Organizer and then...later...directly, the after_performs are skipped when calling directly. This is due to how Organizers handle Interactors with deferred logic. In such a case, the Organizer modifies the Interactor's callback so that it is skipped. However, this does not account for cases where an Interactor is called both as part of an Organizer and on it's own. In this case, the Interactor believes it should skip handling the after_performs forever, and rely instead on the Organizer to call them at the appropriate time. This change updates the logic so that the callback is only skipped if the organizer property is not present. This property is used to tell the Interactor that and by what it is being "organized".
mjonas87
force-pushed
the
fix-dual-call-issue
branch
from
69b8be6 to
cb5bc7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix dual call issue with interactors with deferred after_performs
If an Interactor that has deferred after_performs is called from an Organizer and then...later...directly, the after_performs are skipped when calling directly.
This is due to how Organizers handle Interactors with deferred logic. In such a case, the Organizer modifies the Interactor's callback so that it is skipped. However, this does not account for cases where an Interactor is called both as part of an Organizer and on it's own. In this case, the Interactor believes it should skip handling the after_performs forever, and rely instead on the Organizer to call them at the appropriate time.
This change updates the logic so that the callback is only skipped if the organizer property is not present. This property is used to tell the Interactor that and by what it is being "organized".
Information
[ ] Contains Documentation[ ] Contains Breaking ChangesFixed