Skip to content

Upgrade to .NET 10 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaofbvieira merged 2 commits into from
Jan 12, 2026
Merged

Upgrade to .NET 10 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8956ad
Upgrade to .NET 10
joaofbvieira Jan 12, 2026
a7600e7
Re-generate api client with latest version of nswag
joaofbvieira Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
if: ${{ github.actor == 'dependabot[bot]' }}
steps:
- name: Merge non major updates
uses: trakx/github-actions/dependabot-automerge@v10.1.2
uses: trakx/github-actions/dependabot-automerge@v10.2.9

Check warning on line 15 in .github/workflows/automerge.yml

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

.github/workflows/automerge.yml#L15 

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@

- name: Build and publish nuget packages
id: publish
uses: trakx/github-actions/publish-nuget@v10.1.2
uses: trakx/github-actions/publish-nuget@v10.2.9

Check warning on line 60 in .github/workflows/nuget.yml

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

.github/workflows/nuget.yml#L60 

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
packageReadonlyPat: ${{secrets.TRAKX_BOT_READONLY_PAT}}
githubToken: ${{secrets.GITHUB_TOKEN}}
debuggable: ${{steps.default-inputs.outputs.debuggable}}
semverIncrementLevel: ${{steps.default-inputs.outputs.semverIncrementLevel}}
dotnetVersion: 8.x
dotnetVersion: 10.x
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
steps:
- name: Test and cover solutions
id: test
uses: trakx/github-actions/test-dotnet@v10.1.2
uses: trakx/github-actions/test-dotnet@v10.2.9

Check warning on line 17 in .github/workflows/test.yml

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

.github/workflows/test.yml#L17 

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
with:
packageReadonlyPat: ${{secrets.TRAKX_BOT_READONLY_PAT}}
codacyToken: ${{secrets.CODACY_TOKEN}}
awsAccessKeyId: ${{secrets.AWS_ACCESS_KEY_ID}}
awsAccessKeySecret: ${{secrets.AWS_ACCESS_KEY_SECRET}}
dotnetVersion: 8.x
dotnetVersion: 10.x
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
[![Build and Test](https://github.com/trakx/circle-api-client/actions/workflows/test.yml/badge.svg)](https://github.com/trakx/circle-api-client/actions/workflows/test.yml)
[![Codacy Badge](https://app.codacy.com/project/badge/Grade/a11f6875244948d39af6c2350095490f)](https://www.codacy.com/gh/trakx/circle-api-client/dashboard?utm_source=github.com&utm_medium=referral&utm_content=trakx/circle-api-client&utm_campaign=Badge_Grade)
[![Codacy Badge](https://app.codacy.com/project/badge/Coverage/435670815af049dc879feaa3cfd7cc81)](https://www.codacy.com/gh/trakx/circle-api-client/dashboard?utm_source=github.com&utm_medium=referral&utm_content=trakx/circle-api-client&utm_campaign=Badge_Coverage)

# circle-api-client
C# implementation of a Circle api client
Expand Down
4 changes: 2 additions & 2 deletions src/Common.Projects.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<Company>Trakx</Company>
<Copyright>Copyright © 2024 Trakx</Copyright>
<Copyright>Copyright © 2026 Trakx</Copyright>
<RepositoryUrl>https://github.com/trakx/circle-api-client</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<Deterministic>true</Deterministic>
Expand All @@ -14,7 +14,7 @@
<LangVersion>latest</LangVersion>
</PropertyGroup>
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
</PropertyGroup>
<PropertyGroup Condition=" '$(Version)' == '' ">
<VersionPrefix Condition=" '$(VersionPrefix)' == '' ">0.1.0</VersionPrefix>
Expand Down
4 changes: 2 additions & 2 deletions src/Trakx.Circle.ApiClient.Tests/Integration/BusinessAccountTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
var bankRequest = _mockCreator.GetSignetWireCreationRequest();
Logger.Information("Creating a signet bank account with IdempotencyKey {IdempotencyKey}", bankRequest.IdempotencyKey);

var result = await _businessAccountClient.CreateSignetBankAsync(bankRequest);

Check failure on line 52 in src/Trakx.Circle.ApiClient.Tests/Integration/BusinessAccountTest.cs

View workflow job for this annotation

GitHub Actions / test

Trakx.Circle.ApiClient.Tests.Integration.BusinessAccountTest.Create_Signet_Bank_Should_Be_Successful 

Trakx.Circle.ApiClient.ApiException : The HTTP status code of the response was not expected (405).

Status: 405
Response: 
{"code":-1,"message":"Something went wrong. errId: 63e4b933-b90f-40e9-80f3-7a9a29f0bed4"}

result.Content.Data.TrackingRef.Should().NotBeNullOrEmpty();
result.Content.Data.WalletAddress.Should().NotBeNullOrEmpty();
Expand All @@ -63,7 +63,7 @@
var bankRequest = _mockCreator.GetSilverGateSenBankRequest;
Logger.Information("Creating a silver gate bank account with IdempotencyKey {IdempotencyKey}", bankRequest.IdempotencyKey);

var result = await _businessAccountClient.CreateSilverGateBankAsync(bankRequest);

Check failure on line 66 in src/Trakx.Circle.ApiClient.Tests/Integration/BusinessAccountTest.cs

View workflow job for this annotation

GitHub Actions / test

Trakx.Circle.ApiClient.Tests.Integration.BusinessAccountTest.Create_SilverGate_Bank_Should_Be_Successful 

Trakx.Circle.ApiClient.ApiException`1[[Trakx.Circle.ApiClient.Error, Trakx.Circle.ApiClient, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null]] : The specified resource was not found.

Status: 404
Response:

result.Content.Data.TrackingRef.Should().NotBeNullOrEmpty();
result.Content.Data.Description.Should().NotBeNullOrEmpty();
Expand All @@ -75,7 +75,7 @@
[Fact]
public async Task Get_SilverGate_Bank_Should_Be_Successful()
{
var result = await _businessAccountClient.GetSilverGateBanksAsync();

Check failure on line 78 in src/Trakx.Circle.ApiClient.Tests/Integration/BusinessAccountTest.cs

View workflow job for this annotation

GitHub Actions / test

Trakx.Circle.ApiClient.Tests.Integration.BusinessAccountTest.Get_SilverGate_Bank_Should_Be_Successful 

Trakx.Circle.ApiClient.ApiException : The HTTP status code of the response was not expected (404).

Status: 404
Response: 
{"code":-1,"message":"Resource not found"}

result.Content.Data.Should().NotBeNullOrEmpty();

Expand Down Expand Up @@ -109,8 +109,8 @@
Logger.Information("{Amount} {Currency}", money.Amount, money.Currency);
}

availableBalance.Should().HaveCountGreaterOrEqualTo(minCount);
result.Content.Data.Unsettled.Should().HaveCountGreaterOrEqualTo(minCount);
availableBalance.Should().HaveCountGreaterThanOrEqualTo(minCount);
result.Content.Data.Unsettled.Should().HaveCountGreaterThanOrEqualTo(minCount);
result.StatusCode.Should().Be(StatusCodes.Status200OK);
}
[Fact(Skip = "Payment SilverGate payment not working now")]
Expand Down
23 changes: 11 additions & 12 deletions src/Trakx.Circle.ApiClient.Tests/Trakx.Circle.ApiClient.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,26 @@
<Import Project="../Common.Projects.props" />

<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="6.0.1">
<PackageReference Include="coverlet.msbuild" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="DotNetEnv" Version="3.0.0" />
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="GitHubActionsTestLogger" Version="2.3.3">
<PackageReference Include="DotNetEnv" Version="3.1.1" />
<PackageReference Include="GitHubActionsTestLogger" Version="3.0.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="Serilog.Sinks.XUnit" Version="3.0.5" />
<PackageReference Include="Trakx.Common.Testing.Documentation" Version="1.0.4" />
<PackageReference Include="xunit" Version="2.7.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.1" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="Serilog.Sinks.XUnit" Version="3.0.19" />
<PackageReference Include="Trakx.Common.Testing.Documentation" Version="2.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.1">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
Loading
Loading