This repository was archived by the owner on Sep 4, 2025. It is now read-only.
AddInternalAsync refactor and explicit RemoveAsync#92
Merged
emanuelgaspar merged 5 commits intodevfrom May 24, 2023
Merged
Conversation
…rnalAsync is called with SubRemove
emanuelgaspar
requested review from
TiagoFroisPereira,
goneneren,
joaofbvieira and
monsieurleberre
emanuelgaspar
changed the title
AddInternalAsync refactor when removing subscriptionsAddInternalAsync refactor and explicit RemoveAsync
goneneren
reviewed
May 24, 2023
goneneren
reviewed
May 24, 2023
goneneren
suggested changes
May 24, 2023
goneneren
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detection of trying to
SubRemovesubcriptions when callingAddInternalAsyncwas difficult to understand due to its use ofJsonDocument.Parse(subscription.Topic).This PR introduces a strongly-typed deserialization of the topic, which allows us to work on the array of subs with clean code.
New
RemoveAsync(TopicSubscription subscription)method added toICryptoCompareWebsocketHandler.There's one from the base interface in
websocketswhich takes anIListof subscriptions, but doesn't do what we need inmarket-data.Also bumped some nuget/actions versions.