Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Nuget bumps, fix IDE warnings and messages, nullable properties#96

Merged
emanuelgaspar merged 3 commits intodevfrom
feature/nuget-bumps
Oct 31, 2023
Merged

Nuget bumps, fix IDE warnings and messages, nullable properties#96
emanuelgaspar merged 3 commits intodevfrom
feature/nuget-bumps

Conversation

@emanuelgaspar
Copy link
Copy Markdown
Contributor

Nuget bumps
Fix IDE warnings and messages
Nullable properties

Fix issue found in marketdata-collector:

 at Trakx.CryptoCompare.ApiClient.Websocket.CryptoCompareWebsocketHandler.DeserializeClientSocketIncoming(String topic, IncomingMessage m)
   at System.Text.Json.JsonSerializer.Deserialize(String json, Type returnType, JsonSerializerOptions options)
   ...
System.TypeLoadException: Could not load type 'Trakx.Common.Serialization.Converters.ULongOrStringConverter' from assembly 'Trakx.Common, Version=0.2.2.0, Culture=neutral, PublicKeyToken=null'.

@emanuelgaspar emanuelgaspar marked this pull request as draft October 30, 2023 18:02
@emanuelgaspar emanuelgaspar marked this pull request as ready for review October 30, 2023 18:04
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Oct 30, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.77% 37.23%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7cb9abc) 1765 1060 60.06%
Head commit (41af74a) 1766 (+1) 1047 (-13) 59.29% (-0.77%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#96) 137 51 37.23%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Copy Markdown
Contributor

@monsieurleberre monsieurleberre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@emanuelgaspar emanuelgaspar merged commit 11c8127 into dev Oct 31, 2023
@emanuelgaspar emanuelgaspar deleted the feature/nuget-bumps branch October 31, 2023 13:44
emanuelgaspar added a commit that referenced this pull request Nov 2, 2023
* chore: Bump trakx/bump-version-action from 8 to 9.0.0 (#22)

Bumps [trakx/bump-version-action](https://github.com/trakx/bump-version-action) from 8 to 9.0.0.
- [Release notes](https://github.com/trakx/bump-version-action/releases)
- [Commits](trakx/github-actions@v8...v9.0.0)

---
updated-dependencies:
- dependency-name: trakx/bump-version-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump anothrNick/github-tag-action from 1.38.0 to 1.39.0 (#23)

Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/anothrNick/github-tag-action/releases)
- [Commits](anothrNick/github-tag-action@1.38.0...1.39.0)

---
updated-dependencies:
- dependency-name: anothrNick/github-tag-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump Trakx.Utils.Testing from 0.3.1 to 0.3.11 (#25)

Bumps Trakx.Utils.Testing from 0.3.1 to 0.3.11.

---
updated-dependencies:
- dependency-name: Trakx.Utils.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* chore: Bump Trakx.Utils from 0.3.1 to 0.3.11 (#26)

Bumps Trakx.Utils from 0.3.1 to 0.3.11.

---
updated-dependencies:
- dependency-name: Trakx.Utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* chore: Bump FluentAssertions from 6.5.1 to 6.6.0 (#24)

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.5.1 to 6.6.0.
- [Release notes](https://github.com/fluentassertions/fluentassertions/releases)
- [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1)
- [Commits](fluentassertions/fluentassertions@6.5.1...6.6.0)

---
updated-dependencies:
- dependency-name: FluentAssertions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* chore: Bump trakx/bump-version-action from 9.0.0 to 9.0.1 (#27)

Bumps [trakx/bump-version-action](https://github.com/trakx/bump-version-action) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/trakx/bump-version-action/releases)
- [Commits](trakx/github-actions@v9.0.0...v9.0.1)

---
updated-dependencies:
- dependency-name: trakx/bump-version-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump GitHubActionsTestLogger from 1.3.0 to 1.4.1 (#29)

Bumps [GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger) from 1.3.0 to 1.4.1.
- [Release notes](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)
- [Changelog](https://github.com/Tyrrrz/GitHubActionsTestLogger/blob/master/Changelog.md)
- [Commits](Tyrrrz/GitHubActionsTestLogger@1.3...1.4.1)

---
updated-dependencies:
- dependency-name: GitHubActionsTestLogger
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump Trakx.Utils from 0.3.11 to 0.3.13 (#36)

Bumps Trakx.Utils from 0.3.11 to 0.3.13.

---
updated-dependencies:
- dependency-name: Trakx.Utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Bump Serilog from 2.10.0 to 2.11.0 (#32)

Bumps [Serilog](https://github.com/serilog/serilog) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/serilog/serilog/releases)
- [Changelog](https://github.com/serilog/serilog/blob/dev/CHANGES.md)
- [Commits](serilog/serilog@v2.10.0...v2.11.0)

---
updated-dependencies:
- dependency-name: Serilog
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* chore: Bump Trakx.Utils.Testing from 0.3.11 to 0.3.13 (#35)

Bumps Trakx.Utils.Testing from 0.3.11 to 0.3.13.

---
updated-dependencies:
- dependency-name: Trakx.Utils.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* update bump-version

* update packages

* refactor: rename from/to symbol to base/quote

* Update to .Net 7
Update pipeline to support .net7

* PUMP Trakx.WebSocket to latest version

* Fix unit test

* Update pipeline

* Update src/Trakx.CryptoCompare.ApiClient.Websocket.Tests/Integration/CryptoCompareWebsocketHandlerTests.cs

Co-authored-by: Emanuel Gaspar <emanuel@cognip.com>

* Update .github/workflows/automerge.yml

Co-authored-by: Emanuel Gaspar <emanuel@cognip.com>

* Update .github/workflows/nuget.yml

Co-authored-by: Emanuel Gaspar <emanuel@cognip.com>

* fix issue in pipeline

* Update to get the configuration in test from AWS

* refactor: explicit method and strongly typed deserialize when AddInternalAsync is called with SubRemove

* chore: version bumps

* chore: testing coverlet bump to v6

* feat: explicit RemoveAsync with single TopicSubscription; more test coverage

* Gonen's feedback (thanks)

* ensure configuration is loaded from AWS, from CiCd or Development

* ensure tests pass at all times

* remove Development environment from test config

* increase buffer window to 30 seconds

* Update .github/workflows/delete.packages.yml

Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* Update .github/workflows/delete.packages.yml

Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>

* Nuget bumps, fix IDE warnings and messages, nullable properties (#96)

* nuget bumps, fix IDE warnings and messages, nullable properties

* flags in plural

* Pascal case

* chore: Bump trakx/github-actions from 10.0.14 to 10.0.26 (#97)

Bumps [trakx/github-actions](https://github.com/trakx/github-actions) from 10.0.14 to 10.0.26.
- [Release notes](https://github.com/trakx/github-actions/releases)
- [Commits](trakx/github-actions@v10.0.14...v10.0.26)

---
updated-dependencies:
- dependency-name: trakx/github-actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emanuel Gaspar <emanuel@cognip.com>

* nuget bumps, dependabot is failing

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieurleberre@users.noreply.github.com>
Co-authored-by: monsieurleberre <monsieur.leberre@gmail.com>
Co-authored-by: TiagoFroisPereira <tfroisip@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants